-
Notifications
You must be signed in to change notification settings - Fork 313
Add graalvm25 image to testing #9562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🎯 Code Coverage 🔗 Commit SHA: ca67bab | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~ca67bab57c, baseline=1.54.0-SNAPSHOT~c096994488
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.013 s) : 0, 1012959
Total [baseline] (8.653 s) : 0, 8652608
Agent [candidate] (1.015 s) : 0, 1014637
Total [candidate] (8.688 s) : 0, 8687584
section iast
Agent [baseline] (1.151 s) : 0, 1151078
Total [baseline] (9.245 s) : 0, 9245331
Agent [candidate] (1.153 s) : 0, 1153277
Total [candidate] (9.265 s) : 0, 9264514
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~ca67bab57c, baseline=1.54.0-SNAPSHOT~c096994488
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (694.858 ms) : 0, 694858
BytebuddyAgent [candidate] (692.507 ms) : 0, 692507
GlobalTracer [baseline] (236.771 ms) : 0, 236771
GlobalTracer [candidate] (238.04 ms) : 0, 238040
AppSec [baseline] (32.731 ms) : 0, 32731
AppSec [candidate] (33.325 ms) : 0, 33325
Debugger [baseline] (6.37 ms) : 0, 6370
Debugger [candidate] (6.443 ms) : 0, 6443
Remote Config [baseline] (677.03 µs) : 0, 677
Remote Config [candidate] (706.096 µs) : 0, 706
Telemetry [baseline] (9.047 ms) : 0, 9047
Telemetry [candidate] (9.134 ms) : 0, 9134
Flare Poller [baseline] (9.658 ms) : 0, 9658
Flare Poller [candidate] (11.833 ms) : 0, 11833
section iast
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (819.336 ms) : 0, 819336
BytebuddyAgent [candidate] (819.62 ms) : 0, 819620
GlobalTracer [baseline] (228.13 ms) : 0, 228130
GlobalTracer [candidate] (229.399 ms) : 0, 229399
IAST [baseline] (26.513 ms) : 0, 26513
IAST [candidate] (26.723 ms) : 0, 26723
AppSec [baseline] (35.246 ms) : 0, 35246
AppSec [candidate] (35.322 ms) : 0, 35322
Debugger [baseline] (6.057 ms) : 0, 6057
Debugger [candidate] (6.116 ms) : 0, 6116
Remote Config [baseline] (587.351 µs) : 0, 587
Remote Config [candidate] (593.082 µs) : 0, 593
Telemetry [baseline] (8.236 ms) : 0, 8236
Telemetry [candidate] (8.352 ms) : 0, 8352
Flare Poller [baseline] (4.275 ms) : 0, 4275
Flare Poller [candidate] (4.337 ms) : 0, 4337
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~ca67bab57c, baseline=1.54.0-SNAPSHOT~c096994488
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.017 s) : 0, 1017486
Total [baseline] (9.693 s) : 0, 9693481
Agent [candidate] (1.016 s) : 0, 1016355
Total [candidate] (10.782 s) : 0, 10782352
section appsec
Agent [baseline] (1.196 s) : 0, 1196441
Total [baseline] (11.101 s) : 0, 11101196
Agent [candidate] (1.19 s) : 0, 1189733
Total [candidate] (11.086 s) : 0, 11085636
section iast
Agent [baseline] (1.148 s) : 0, 1147513
Total [baseline] (10.876 s) : 0, 10875714
Agent [candidate] (1.161 s) : 0, 1161171
Total [candidate] (11.179 s) : 0, 11178924
section profiling
Agent [baseline] (1.176 s) : 0, 1175691
Total [baseline] (11.177 s) : 0, 11176846
Agent [candidate] (1.156 s) : 0, 1155815
Total [candidate] (11.058 s) : 0, 11057540
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~ca67bab57c, baseline=1.54.0-SNAPSHOT~c096994488
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.488 ms) : 0, 1488
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (696.592 ms) : 0, 696592
BytebuddyAgent [candidate] (693.881 ms) : 0, 693881
GlobalTracer [baseline] (238.928 ms) : 0, 238928
GlobalTracer [candidate] (238.982 ms) : 0, 238982
AppSec [baseline] (33.129 ms) : 0, 33129
AppSec [candidate] (33.151 ms) : 0, 33151
Debugger [baseline] (6.506 ms) : 0, 6506
Debugger [candidate] (6.492 ms) : 0, 6492
Remote Config [baseline] (695.639 µs) : 0, 696
Remote Config [candidate] (702.601 µs) : 0, 703
Telemetry [baseline] (9.114 ms) : 0, 9114
Telemetry [candidate] (9.136 ms) : 0, 9136
Flare Poller [baseline] (9.596 ms) : 0, 9596
Flare Poller [candidate] (11.184 ms) : 0, 11184
section appsec
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.475 ms) : 0, 1475
BytebuddyAgent [baseline] (720.904 ms) : 0, 720904
BytebuddyAgent [candidate] (716.861 ms) : 0, 716861
GlobalTracer [baseline] (231.959 ms) : 0, 231959
GlobalTracer [candidate] (230.22 ms) : 0, 230220
AppSec [baseline] (175.527 ms) : 0, 175527
AppSec [candidate] (174.895 ms) : 0, 174895
Debugger [baseline] (6.135 ms) : 0, 6135
Debugger [candidate] (6.124 ms) : 0, 6124
Remote Config [baseline] (659.954 µs) : 0, 660
Remote Config [candidate] (646.765 µs) : 0, 647
Telemetry [baseline] (9.161 ms) : 0, 9161
Telemetry [candidate] (9.091 ms) : 0, 9091
Flare Poller [baseline] (4.017 ms) : 0, 4017
Flare Poller [candidate] (3.982 ms) : 0, 3982
IAST [baseline] (25.376 ms) : 0, 25376
IAST [candidate] (25.269 ms) : 0, 25269
section iast
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.479 ms) : 0, 1479
BytebuddyAgent [baseline] (815.234 ms) : 0, 815234
BytebuddyAgent [candidate] (824.68 ms) : 0, 824680
GlobalTracer [baseline] (227.999 ms) : 0, 227999
GlobalTracer [candidate] (230.967 ms) : 0, 230967
AppSec [baseline] (35.547 ms) : 0, 35547
AppSec [candidate] (35.82 ms) : 0, 35820
Debugger [baseline] (6.08 ms) : 0, 6080
Debugger [candidate] (6.217 ms) : 0, 6217
Remote Config [baseline] (599.614 µs) : 0, 600
Remote Config [candidate] (600.21 µs) : 0, 600
Telemetry [baseline] (8.223 ms) : 0, 8223
Telemetry [candidate] (8.443 ms) : 0, 8443
Flare Poller [baseline] (4.336 ms) : 0, 4336
Flare Poller [candidate] (4.264 ms) : 0, 4264
IAST [baseline] (26.816 ms) : 0, 26816
IAST [candidate] (27.259 ms) : 0, 27259
section profiling
ProfilingAgent [baseline] (105.586 ms) : 0, 105586
ProfilingAgent [candidate] (103.431 ms) : 0, 103431
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (733.022 ms) : 0, 733022
BytebuddyAgent [candidate] (721.071 ms) : 0, 721071
GlobalTracer [baseline] (217.412 ms) : 0, 217412
GlobalTracer [candidate] (214.206 ms) : 0, 214206
AppSec [baseline] (33.248 ms) : 0, 33248
AppSec [candidate] (32.589 ms) : 0, 32589
Debugger [baseline] (8.234 ms) : 0, 8234
Debugger [candidate] (6.514 ms) : 0, 6514
Remote Config [baseline] (778.17 µs) : 0, 778
Remote Config [candidate] (809.771 µs) : 0, 810
Telemetry [baseline] (15.05 ms) : 0, 15050
Telemetry [candidate] (16.515 ms) : 0, 16515
Flare Poller [baseline] (4.281 ms) : 0, 4281
Flare Poller [candidate] (4.182 ms) : 0, 4182
Profiling [baseline] (109.516 ms) : 0, 109516
Profiling [candidate] (106.628 ms) : 0, 106628
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~ca67bab57c, baseline=1.54.0-SNAPSHOT~c096994488
dateFormat X
axisFormat %s
section baseline
no_agent (4.364 ms) : 4315, 4413
. : milestone, 4364,
iast (9.943 ms) : 9778, 10107
. : milestone, 9943,
iast_FULL (14.021 ms) : 13740, 14303
. : milestone, 14021,
iast_GLOBAL (10.972 ms) : 10774, 11170
. : milestone, 10972,
profiling (8.409 ms) : 8279, 8539
. : milestone, 8409,
tracing (7.704 ms) : 7597, 7812
. : milestone, 7704,
section candidate
no_agent (4.471 ms) : 4421, 4522
. : milestone, 4471,
iast (9.66 ms) : 9497, 9822
. : milestone, 9660,
iast_FULL (14.876 ms) : 14584, 15169
. : milestone, 14876,
iast_GLOBAL (10.596 ms) : 10410, 10781
. : milestone, 10596,
profiling (8.694 ms) : 8559, 8829
. : milestone, 8694,
tracing (7.998 ms) : 7874, 8122
. : milestone, 7998,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~ca67bab57c, baseline=1.54.0-SNAPSHOT~c096994488
dateFormat X
axisFormat %s
section baseline
no_agent (37.217 ms) : 36920, 37515
. : milestone, 37217,
appsec (50.794 ms) : 50341, 51247
. : milestone, 50794,
code_origins (43.764 ms) : 43394, 44134
. : milestone, 43764,
iast (45.255 ms) : 44873, 45636
. : milestone, 45255,
profiling (48.088 ms) : 47643, 48534
. : milestone, 48088,
tracing (45.329 ms) : 44933, 45724
. : milestone, 45329,
section candidate
no_agent (37.101 ms) : 36808, 37394
. : milestone, 37101,
appsec (48.278 ms) : 47845, 48712
. : milestone, 48278,
code_origins (44.037 ms) : 43658, 44415
. : milestone, 44037,
iast (44.367 ms) : 43983, 44751
. : milestone, 44367,
profiling (49.423 ms) : 48912, 49934
. : milestone, 49423,
tracing (44.017 ms) : 43625, 44408
. : milestone, 44017,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~ca67bab57c, baseline=1.54.0-SNAPSHOT~c096994488
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1471, 1494
. : milestone, 1482,
appsec (2.479 ms) : 2428, 2529
. : milestone, 2479,
iast (2.222 ms) : 2159, 2286
. : milestone, 2222,
iast_GLOBAL (2.27 ms) : 2206, 2333
. : milestone, 2270,
profiling (2.089 ms) : 2036, 2142
. : milestone, 2089,
tracing (2.03 ms) : 1981, 2080
. : milestone, 2030,
section candidate
no_agent (1.48 ms) : 1469, 1492
. : milestone, 1480,
appsec (3.73 ms) : 3511, 3949
. : milestone, 3730,
iast (2.214 ms) : 2151, 2278
. : milestone, 2214,
iast_GLOBAL (2.262 ms) : 2198, 2326
. : milestone, 2262,
profiling (2.084 ms) : 2032, 2137
. : milestone, 2084,
tracing (2.035 ms) : 1986, 2085
. : milestone, 2035,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~ca67bab57c, baseline=1.54.0-SNAPSHOT~c096994488
dateFormat X
axisFormat %s
section baseline
no_agent (15.603 s) : 15603000, 15603000
. : milestone, 15603000,
appsec (14.975 s) : 14975000, 14975000
. : milestone, 14975000,
iast (18.665 s) : 18665000, 18665000
. : milestone, 18665000,
iast_GLOBAL (18.113 s) : 18113000, 18113000
. : milestone, 18113000,
profiling (15.539 s) : 15539000, 15539000
. : milestone, 15539000,
tracing (15.273 s) : 15273000, 15273000
. : milestone, 15273000,
section candidate
no_agent (14.953 s) : 14953000, 14953000
. : milestone, 14953000,
appsec (15.107 s) : 15107000, 15107000
. : milestone, 15107000,
iast (18.664 s) : 18664000, 18664000
. : milestone, 18664000,
iast_GLOBAL (18.29 s) : 18290000, 18290000
. : milestone, 18290000,
profiling (15.749 s) : 15749000, 15749000
. : milestone, 15749000,
tracing (14.957 s) : 14957000, 14957000
. : milestone, 14957000,
|
506ec84
to
b191c6f
Compare
// quick build mode, enough for smoke test | ||
buildArgs.add("-Ob") | ||
buildArgs.add("-J-javaagent:$agentPath") | ||
buildArgs.add("-J-Dnet.bytebuddy.safe=false") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still needed after #9569
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I believe the net.bytebuddy.nexus.disabled
flag from #9569 relates to the Nexus mechanism specifically (that uses Unsafe
), while this PR's flag is the one that resolves the Cannot get defined package using reflection: Use of Unsafe was disabled by system property
error.
76c6260
to
6f9f05d
Compare
What Does This Do
Add Graalvm 25 image testing to CI
Motivation
Additional Notes
The current failure has to do with JFR initialization.
Adding the
-XX:StartFlightRecording=filename=${testJfrDir}/recording.jfr
flag to thecreateProcessBuilder()
method in thedd-smoke-tests/spring-boot-3.0-native/src/test/groovy/SpringBootNativeInstrumentationTest.groovy
file resolves the issue, but this flag should not be necessary because we're using the Java API to start the recording.Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: https://datadoghq.atlassian.net/browse/LANGPLAT-83